Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the system scoring #622

Closed
MrDeshaies opened this issue Mar 7, 2021 · 1 comment · Fixed by #865 or #913
Closed

About the system scoring #622

MrDeshaies opened this issue Mar 7, 2021 · 1 comment · Fixed by #865 or #913
Assignees
Labels
bug Something isn't working
Milestone

Comments

@MrDeshaies
Copy link
Contributor

In Section 5 "About the system", the "other" has value "item6-1". The -1 is to increase the score, but since this is in a "no score" (NS) section ("aboutSystemPanel-NS") it has no effect. The -1 should be removed to avoid confusion (for developers). Be careful to also update the "Please describe" which uses the -1 reference in its "visibleIf"

@MrDeshaies MrDeshaies added the bug Something isn't working label Mar 7, 2021
@MrDeshaies MrDeshaies self-assigned this Mar 7, 2021
@MrDeshaies MrDeshaies added this to the 0.9.1 milestone Nov 10, 2021
@Ancentury Ancentury linked a pull request Nov 22, 2021 that will close this issue
@Ancentury Ancentury self-assigned this Nov 23, 2021
MrDeshaies added a commit that referenced this issue Feb 18, 2022
@MrDeshaies
Copy link
Contributor Author

This causes a little problem when loading old files created before this fix was implemented; the "other" value gets unchecked on loading even though it was checked in the old version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants