This repository has been archived by the owner on Apr 1, 2021. It is now read-only.
Carousel: Update children if different (needed for the Hub #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 93.47% (diff: 100%)@@ v2.0.0 #71 diff @@
==========================================
Files 29 29
Lines 2436 2436
Methods 416 414 -2
Messages 0 0
Branches 207 209 +2
==========================================
Hits 2277 2277
Misses 159 159
Partials 0 0
|
ldestin
approved these changes
Dec 19, 2016
FlorentD
suggested changes
Dec 19, 2016
| @@ -91,7 +92,7 @@ class Carousel extends Component { | |||
| } | |||
|
|
|||
| componentWillUpdate({ children }) { | |||
| if (this.props.children.length === 0) { | |||
| if (!isEqual(children, this.props.children)) { | |||
There was a problem hiding this comment.
Why not using hasDiff.js function ?
We don't want to create a new dependency to lodash.
MorganeLecurieux
force-pushed
the
Carousel-reload-children
branch
from
275daca
to
00718ef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case the second Carousel need to display different children according to the first Carousel, it won't work with the actual version.
This is a fix to make this work.