For dynamic contents, always set a very high duration #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found out that the video element's `duration` property for live contents was sometimes very close to the maximum position, whereas it should be set to very high number for such types of contents. The reason behind this issue was very clear: the `MediaDurationUpdater` only performed a live-specific logic when the current tracks' duration are initially not known whereas it should do it everytime the duration may need to be updated.
peaBerberian
added
bug
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that the video element's
durationproperty for live contents was sometimes very close to the maximum position, whereas it should be set to very high number for such types of contents.The reason behind this issue was very clear: the
MediaDurationUpdateronly performed a live-specific logic when the current tracks' duration are initially not known whereas it should do it everytime the duration may need to be updated.