-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
force-pushed
the
misc/group-codecs-warning
branch
from
July 21, 2023 16:07
f1872d3
to
9723c9a
Compare
peaBerberian
force-pushed
the
misc/group-codecs-warning
branch
2 times, most recently
from
July 24, 2023 12:52
e907fa5
to
79fedda
Compare
peaBerberian
force-pushed
the
misc/group-codecs-warning
branch
from
July 24, 2023 19:20
79fedda
to
0a20b24
Compare
peaBerberian
force-pushed
the
misc/group-codecs-warning
branch
from
August 7, 2023 16:43
0a20b24
to
5977744
Compare
peaBerberian
force-pushed
the
misc/group-codecs-warning
branch
from
August 22, 2023 14:38
5977744
to
2bbf4b9
Compare
peaBerberian
added a commit
that referenced
this pull request
Aug 23, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Aug 31, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Aug 31, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Aug 31, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Sep 15, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Sep 15, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Sep 22, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Sep 26, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Sep 26, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Sep 27, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Sep 27, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Sep 27, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Sep 29, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
Merged
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Oct 19, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
peaBerberian
added a commit
that referenced
this pull request
Oct 26, 2023
[Proposal] [v4] Errors: Replace trackInfo prop by tracksInfo to group similar errors
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing many tests, it seems that the strategy of sending a
MANIFEST_INCOMPATIBLE_CODECS_ERROR
warning each time we spot an audio or video AdaptationSet with no supported codec in the MPD is not optimal for very large MPD (or equivalent in smooth streaming / local Manifests / MetaPlaylists).Specifically, MPD with a very large amount of unsupported AdaptationSet (multi-Period MPDs, MPDs with a large choice of AdaptationSet with multiple codecs, dynamic range, audio channels, or all of this together), might produce A LOT of warnings - even more for contents where the Manifest has to be updated.
In turn, those warnings produce a lot of uninteresting warning logs, and might have in some extreme cases a non-null impact on memory as parsing issues were until known stored as a property of the Manifest instance (still less than a MB in the current worst observed cases - so not THAT problematic either, but still).
This PR propose for the v4 the following changes:
All
MANIFEST_INCOMPATIBLE_CODECS_ERROR
warnings seen while parsing a Manifest are regrouped into one - even when talking about media of different types (i.e. "audio" and "video")The
trackInfo
stored on someMediaError
s is now renamed intotracksInfo
(with an s) and is now an Array of tracks - to allow warnings for multiple tracks at once. This is sadly a breaking change - it is relatively minor astrackInfo
was optional and a very recent addition - but still, we only authorize ourselves this on the v4 because it is still in beta.A Manifest instance does not "store" the warnings as a property as this is not needed by anything and this is not in the API. This was mainly done because it was the simplest way to implement it - but grouping warnings together now need a more advanced solution anyway.