DASH_WASM: Update quick-xml (Rust) dependency and consequently update Rust code #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Rust code This commit updates the dependency in our Rust code, `quick-xml`, which allows to parse XML documents (which DASH MPD are) in our WASM MPD parser in a SAX-like manner. The major change here is that the types for element names and attributes is now implemented by single-field structs whose field is the reference to the corresponding name whereas it was directly the reference initially. Thankfully, there's no need to bring that new struct's name in all our pattern-matching cases (which would have been less readable), as calling the `as_ref` method implemented on that struct returns directly the reference we had before (we can thus pattern match on this instead, and keep the previous code for all matched patterns). This is actually what is presented in quick-xml examples so it also seems like the idiomatic way to do it. However the major part of that code is a formatting update, done thanks to the rust-official `rustfmt` tool and code updates based on clippy (official Rust linter) lints. This branch was tested with success on various DASH contents.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the dependency in our Rust code,
quick-xml, which allows to parse XML documents (which DASH MPD are) in our WASM MPD parser in a SAX-like manner.The major change here is that the types for element names and attributes is now implemented by single-field structs whose field is the reference to the corresponding name whereas it was directly the reference initially.
Thankfully, there's no need to bring that new struct's name in all our pattern-matching cases (which would have been less readable), as calling the
as_refmethod implemented on that struct returns directly the reference we had before (we can thus pattern match on this instead, and keep the previous code for all matched patterns).This is actually what is presented in quick-xml examples so it also seems like the idiomatic way to do it.
However the major part of that code is a formatting update, done thanks to the rust-official
rustfmttool and code updates based on clippy (official Rust linter) lints.This branch was tested with success on various DASH contents.