Add unsupported and undecipherable bitrates to the debug element #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug element that might be displayed with the `createDebugElement` method filtered from listed video and audio bitrates those that were not for decipherable or decodable Representation. This makes sense, but it bothered us when debugging why some qualities were not advertised anymore through that window on some difficult-to-debug devices lately: was it an RxPlayer bug, a DRM policy not respected, or codecs that were unsupported. This commit adds audio and video bitrates which are not actually playable, suffixing them by `E!` when it is because it's not decipherable, by `U!` when it's because the codec is not supported, or both (`U! E!`) when it's both.
peaBerberian
commented
Nov 23, 2023
Florent-Bouisset
approved these changes
Dec 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug element that might be displayed with the
createDebugElementmethod filtered from listed video and audio bitrates those that were not for decipherable or decodable Representation.This makes sense, but it bothered us when debugging why some qualities were not advertised anymore through that window on some difficult-to-debug devices lately: was it an RxPlayer bug, a DRM policy not respected, or codecs that were unsupported.
This commit adds audio and video bitrates which are not actually playable, suffixing them by
E!when it is because it's not decipherable, byU!when it's because the codec is not supported, or both (U! E!) when it's both.