-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort locales by language code #429
Conversation
The indenting is inconsistent here. Please follow the tab convention. You'll also need to say something to justify the change. |
Does it look better? |
You still have not given me any good reason to merge this. |
Please assist me. I did sort translations according to language code and indent colons. |
I understand what you did. I do not really understand why, however. Right now this is a change for the sake of a change. I need some better reason for this to be written down. |
I did it so frivolous translators would not accidentally translate Candy into a language that is already available, because they thought that the languages are sorted already. |
I think it would be better to have one file per translation, extending the Otherwise, if you decide to keep this version, please move the English translation where it should be, there is no reason to have an exception to keep it on top imo. Also, please rebase your commits together once you are done and ready for a merge. |
👍 |
See #479 |
I hope I did not break anything