-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive design for mobile #457
Conversation
Looks sweet. Would you mind dropping some representative screenshots here, @pom2ter ? |
This was taken with the Xcode simulator on Mac. it represents the IPhone 5. The roster pane is not completely hidden, enough to show the number of occupants. messages in chat are all align to the left because of the small screen. When the roster pane is opened by clicking/tapping the hamburger icon on the top right, it takes the same space as default. The icon is done in css as i didnt want to add images. |
@benlangfeld So what do you think? Would you be up for running a community demo with this code? Thanks! |
So this is working fine for me. A few requests before I can merge this; would you please
Thanks for the work on this, it's much appreciated! |
ok i made the changes |
Looks good, would you squash for merge @pom2ter? |
Im not sure if it worked, never use squash before. |
Thanks @pom2ter ! |
Here is my take for issue #222 , feedback will be needed.
Basically the roster pane is partially hidden on mobile and a hamburger icon appear at the top right to open / close the pane when clicked.
I added the dependencies (bootstrap) with bower and a couple with grunt (css minification).
CSS changes were made in the default.css file, at the bottom.
As for javascript, i tried to keep the modification to a minimum. What I added is probably not at the best place but it works on my end ;)