Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batched createdInstance and updateInstance in save method (#5518) #514

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

eddypjr
Copy link
Contributor

@eddypjr eddypjr commented Oct 26, 2021

A batch is now started/stopped when properties are created or set on instances. Test written for this behavior.

@eddypjr eddypjr changed the title Batched createdInstance and updateInstance in save method Batched createdInstance and updateInstance in save method (#5518) Oct 26, 2021
Copy link
Contributor

@bmomberger-bitovi bmomberger-bitovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The CanJS test suite passes with this change linked in, so I think it's good to go.

@eddypjr eddypjr merged commit 91a2973 into master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants