Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting a symbol as well as the __inSetup property #69

Merged
merged 1 commit into from
Jan 10, 2019
Merged

setting a symbol as well as the __inSetup property #69

merged 1 commit into from
Jan 10, 2019

Conversation

phillipskevin
Copy link
Contributor

First part of canjs/can-define#421.

@phillipskevin
Copy link
Contributor Author

Don't merge this yet... I'm not sure this is actually required for the can-define issue.

justinbmeyer
justinbmeyer approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@justinbmeyer justinbmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should find other uses of this. Maybe can-event-queue

@phillipskevin
Copy link
Contributor Author

can-define can be fixed without this, but I'm going to merge this anyway so that we can use this Symbol everywhere to be consistent.

@phillipskevin phillipskevin merged commit 2cbbd2d into master Jan 10, 2019
@phillipskevin phillipskevin deleted the in-setup-symbol branch January 10, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinbmeyer justinbmeyer justinbmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillipskevin @justinbmeyer