Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Create a can-event-dom-enter/global module and import it in can/can #18

Open
justinbmeyer opened this issue Mar 7, 2018 · 0 comments

Comments

@justinbmeyer
Copy link
Contributor

Until importing events into templates or other local registries exist, it's cumbersome to require people to do:

var domEvents = require('can-dom-events');
var enterEvent = require('can-event-dom-enter');

domEvents.addEvent(enterEvent);

Until behavior like canjs/can-stache-bindings#440 works, there's no actual integration point for custom events. So, I think we should create a can-event-dom-enter/global module that would add enter to the global registry.

We should make this module part of can/can so people don't have to do this for JSBins.

When we do have custom event registry support, then we can @hide this module.

chasenlehara added a commit to canjs/canjs that referenced this issue Mar 7, 2018
- Instruct the user to install can-stache-route-helpers
- Steal’s deps-bundle shouldn’t be used in this guide
- Fix some of the highlighting
- Fix some broken links
- Show using route.register()
- var => const

Almost everything seems to be working except for the creating todos test, which I think will be fixed by canjs/can-event-dom-enter#18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant