Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken with latest version of feathers #77

Closed
Mattchewone opened this issue May 22, 2019 · 0 comments · Fixed by #78
Closed

broken with latest version of feathers #77

Mattchewone opened this issue May 22, 2019 · 0 comments · Fixed by #78

Comments

@Mattchewone
Copy link
Contributor

After upgrading the packages to the latest of featherjs, the tests for feathers socketio are now failing.

I upgraded the devDependencies as follows:

"devDependencies": {
    "@feathersjs/feathers": "^3.3.1",
    "@feathersjs/socketio-client": "^1.2.1",
    "can-set-legacy": "<2.0.0",
    "detect-cyclic-packages": "^1.1.0",
    "done-serve": "^1.2.0",
    "donejs-cli": "^1.0.1",
    "es6-promise-polyfill": "^1.2.0",
    "generator-donejs": "^1.0.5",
    "jshint": "^2.9.1",
    "object-assign": "^4.1.0",
    "socket.io-client": "^2.2.0",
    "steal": "^1.5.6",
    "steal-qunit": "^1.0.1",
    "steal-tools": "^1.1.2",
    "testee": "^0.9.0"
  }

Then in the test.js file I removed the feathers-hooks package as this is no longer an external dependency:

...
var feathers = require('@feathersjs/feathers');
var feathersSocketio = require('@feathersjs/socketio-client');
...

var app = feathers()
  .configure(feathersSocketio(socket));
...

After making these changes and re-running the tests I see this error "Timeout of 5000ms exceeded calling find on messages".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant