onKeyValue should dispatch the resolved value #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrejewski
reviewed
Nov 1, 2017
| var globals = new Globals(); | ||
| var foo = 'foo'; | ||
| globals.define('foo', ''); | ||
| globals.onKeyValue('foo', function(value){ |
There was a problem hiding this comment.
Good to unbind this listener so it doesn't effect other tests in the future
| @@ -7,6 +7,9 @@ function dispatch(key, value) { | |||
| var handlers = this.eventHandlers[key]; | |||
| if (handlers) { | |||
| var handlersCopy = handlers.slice(); | |||
| if (typeof value === 'function') { | |||
| value = value(); | |||
There was a problem hiding this comment.
Will this fix my can-util problem? Looks like it'll dispatch undefined, when what I need is the default value.
There was a problem hiding this comment.
Nevermind, this should fix my problem, but if value() returns undefined I still expect it to return the default value.
imaustink
commented
Nov 1, 2017
can-globals-proto.js
Outdated
| value = value(); | ||
| } | ||
| if (value === undefined) { | ||
| value = this.properties[key].default; |
There was a problem hiding this comment.
@andrejewski so you're thinking something like this?
There was a problem hiding this comment.
@imaustink Yep. But unless I'm misunderstanding the code, default can also be a function so that would need called as well to return a value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29