Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KeyObservable #23

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Add KeyObservable #23

merged 1 commit into from
Apr 6, 2018

Conversation

chasenlehara
Copy link
Member

I didn’t include docs because the other modules in this package aren’t publicly documented.

Closes #22

justinbmeyer
justinbmeyer reviewed Apr 6, 2018
View reviewed changes
Copy link
Contributor

@justinbmeyer justinbmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change the version, otherwise, looks good

package.json Outdated
@@ -38,6 +38,7 @@
},
"dependencies": {
"can-event-queue": "^1.0.0",
"can-key": "^0.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use <2.0.0

@chasenlehara chasenlehara changed the base branch from master to minor April 6, 2018 19:00
@chasenlehara chasenlehara merged commit 0f7dd36 into minor Apr 6, 2018
@chasenlehara chasenlehara deleted the 22-key-module branch April 6, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinbmeyer justinbmeyer justinbmeyer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chasenlehara @justinbmeyer