Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routeUrl(filter=undefined) puts ?filter=undefined in the URL #11

Open
phillipskevin opened this issue Aug 7, 2018 · 3 comments
Open

Comments

@phillipskevin
Copy link
Contributor

@phillipskevin commented on Mon Aug 06 2018

blob

@phillipskevin
Copy link
Contributor Author

It seems like this only happens if filter is not used in a registered route rule.

can.route.register("{foo}")
can.stache("{{routeUrl(foo=undefined)}}")(); // -> #!
can.stache("{{routeUrl(bar=undefined)}}")(); // -> #!&bar=undefined

@justinbmeyer can you confirm you were seeing something different? Or point me to the code where I can reproduce the issue.

@phillipskevin
Copy link
Contributor Author

2.3 (JSBin) results:

can.route.register("{foo}")
can.stache("{{routeUrl(foo=undefined)}}")(); // -> #!
can.stache("{{routeUrl(bar=undefined)}}")(); // -> #!&bar=

3.0 (JSBin) results:

can.route.register("{foo}")
can.stache("{{routeUrl(foo=undefined)}}")(); // -> #!
can.stache("{{routeUrl(bar=undefined)}}")(); // -> #!&bar=undefined

@phillipskevin
Copy link
Contributor Author

related to canjs/can-route#186.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant