Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Access instance" section to "Work with Android" page #104

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

adglkh
Copy link
Contributor

@adglkh adglkh commented Jul 30, 2024

No description provided.

@adglkh
Copy link
Contributor Author

adglkh commented Jul 30, 2024

We need to get the following PR to be landed first
#99
otherwise, the linkcheck would fail

@canonical/anbox if we all agree on that and put "Access Android instance using anbox-connect" section under the howto/instance/access-to-instance, I'll give @lorumic headup for this. so they could put the link
https://anbox-cloud.io/docs/howto/instance/access#access-android-instance-using-anbox-connect
in the popup dialog

@keirthana keirthana added this to the 1.23.0 milestone Jul 30, 2024
@keirthana
Copy link
Collaborator

keirthana commented Jul 30, 2024

We need to get the following PR to be landed first #99 otherwise, the linkcheck would fail

@canonical/anbox if we all agree on that and put "Access Android instance using anbox-connect" section under the howto/instance/access-to-instance, I'll give @lorumic headup for this. so they could put the link https://anbox-cloud.io/docs/howto/instance/access#access-android-instance-using-anbox-connect in the popup dialog

@morphis I understand your need to putting this prominently but at the moment, this how-to makes the most sense if ADB connect is going to address the user need to access the instance securely. Are there any other use-cases (based on your conversations from customers) that are in play? If this is coming from a perspective of this is a great feature, we need to make it more prominent, I believe we can do that using the release notes.

I am not against writing a tutorial for this but the context needs to be specific - "Connect Android Studio with an Anbox Cloud Instance running on AWS" is a great example as per our MM thread, but I can take that separately outside of the scope of this release. We could even do a video tutorial.

WDYT?

howto/instance/access-instance.md Outdated Show resolved Hide resolved
howto/instance/access-instance.md Outdated Show resolved Hide resolved
howto/instance/access-instance.md Outdated Show resolved Hide resolved
howto/instance/access-instance.md Outdated Show resolved Hide resolved
howto/instance/access-instance.md Outdated Show resolved Hide resolved
howto/instance/access-instance.md Outdated Show resolved Hide resolved
@adglkh adglkh force-pushed the anbox-connect branch 2 times, most recently from fea9ed6 to e99c8aa Compare July 30, 2024 10:09
@adglkh adglkh changed the title Add Access an instance using anbox-connect section to access-instance chapter Add "Access instance" section to "Work with Android" page Jul 30, 2024
howto/android/access-instance.md Outdated Show resolved Hide resolved
howto/android/access-instance.md Outdated Show resolved Hide resolved
howto/android/access-instance.md Outdated Show resolved Hide resolved
howto/android/access-instance.md Outdated Show resolved Hide resolved
howto/android/access-instance.md Show resolved Hide resolved
Introduce `Access Android instance using anbox-connect` section and
add it alongside `Access Android instance via exposed ADB service`
into a separate page under the `Work with Android` page to
differentiate `Access Anbox instance`.

Test: none
Copy link
Collaborator

@keirthana keirthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keirthana
Copy link
Collaborator

Thanks @adglkh for patiently working through this with me. :)

@keirthana keirthana merged commit fcfcaae into canonical:main Aug 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants