crash-digger: Add support for using a gdb-sandbox (plus test case) #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on moving the service which retraces apport crashes in Launchpad to a different server and noticed that while the existing service uses crash-digger it does not take advantage of the GDB sandbox option which I added to apport some time ago. I've added an option to crash-digger, --gdb-sandbox, which is then is then passed through as argument to apport-retrace.
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 82.76% 82.78% +0.02%
==========================================
Files 91 91
Lines 18657 18680 +23
==========================================
+ Hits 15441 15464 +23
Misses 3216 3216
|
|
Thanks for picking up writing the test! I've been quite busy with some other things. |
schopin-pro
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brian was working on moving the service which retraces apport crashes in Launchpad to a different server and noticed that while the existing service uses crash-digger it does not take advantage of the GDB sandbox option which he added to apport some time ago. He has added an option to crash-digger, --gdb-sandbox, which is then is then passed through as argument to apport-retrace.
Also add a test case for crash-digger --gdb-sandbox.