Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD init: use cloudinit_enable as only rcvar #1875

Merged
merged 1 commit into from
Nov 30, 2022
Merged

FreeBSD init: use cloudinit_enable as only rcvar #1875

merged 1 commit into from
Nov 30, 2022

Conversation

igalic
Copy link
Collaborator

@igalic igalic commented Nov 23, 2022 •
edited
Loading

Proposed Commit Message

FreeBSD init: use cloudinit_enable as only rcvar

all components of cloudinit need to run, and in a specific order.
If cloudinit is to be enabled, it should only rely on one variable.
This change better encodes that, than #161 

Sponsored by: FreeBSD Foundation

Additional Context

Currently, when cloud-init isn't enabled, some of its components issue rc warnings.
Previously, in #161 we went overboard, by giving each its own variable

Test Steps

install this patch, reboot, see no more warnings.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@igalic
Copy link
Collaborator Author

igalic commented Nov 23, 2022 •
edited
Loading

cc @Jehops

also cc @kevans91 and @goneri who helped review #161

@Jehops
Copy link
Contributor

Jehops commented Nov 24, 2022

We don't want load_rc_config $rcvar. This will look to source files from places like /etc/rc.conf.d/cloudinit_enable/*.

@igalic
Copy link
Collaborator Author

igalic commented Nov 24, 2022

We don't want load_rc_config $rcvar. This will look to source files from places like /etc/rc.conf.d/cloudinit_enable/*.

oh, right, so, load_rc_config $name or load_rc_config cloudinit would be better here

@TheRealFalcon TheRealFalcon added the wip Work in progress, do not land label Nov 28, 2022
@TheRealFalcon TheRealFalcon self-assigned this Nov 28, 2022
@igalic
FreeBSD init: use cloudinit_enable as only rcvar
3934566 
all components of cloudinit need to run, and in a specific order.
If cloudinit is to be enabled, it should only rely on one variable.
This change better encodes that, than canonical#161

Sponsored by: FreeBSD Foundation
@igalic
Copy link
Collaborator Author

igalic commented Nov 30, 2022 •
edited
Loading

updated the PR now according to @Jehops' comment.

@TheRealFalcon
Copy link
Member

LGTM, but I'll wait for an approval from @Jehops since BSD isn't my wheelhouse.

@TheRealFalcon TheRealFalcon removed the wip Work in progress, do not land label Nov 30, 2022
@Jehops
Copy link
Contributor

Jehops commented Nov 30, 2022 •
edited
Loading

LGTM. Thanks @igalic and @TheRealFalcon.

TheRealFalcon
TheRealFalcon approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheRealFalcon TheRealFalcon merged commit 7a93f1c into canonical:main Nov 30, 2022
@igalic igalic deleted the fix/fbsd-sysvinit branch November 30, 2022 22:37
@blackboxsw blackboxsw mentioned this pull request Dec 15, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

@goneri goneri goneri approved these changes

Assignees

@TheRealFalcon TheRealFalcon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igalic @Jehops @TheRealFalcon @goneri