Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net/networkd): add GatewayOnLink flag when necessary #4996

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

bin456789
Copy link
Contributor

Proposed Commit Message

fix(net/networkd): add GatewayOnLink flag when necessary

When the gateway isn't part of the subnet's network, the "GatewayOnLink" flag is required for the route to work.

Fixes GH-4995

Additional Context

Test Steps

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb holmanb self-assigned this Mar 9, 2024
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bin456789 ; nice work here!

Only thing left to resolve is this branch needs a rebase against main to fix a merge conflict. The conflict is due to additional tests in test_networkd.py, so it should be a straightforward fix.

@bin456789
Copy link
Contributor Author

rebased

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit 45a9b7c into canonical:main Mar 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants