Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlmaLinux OS support #872

Merged
merged 4 commits into from
May 7, 2021
Merged

Add AlmaLinux OS support #872

merged 4 commits into from
May 7, 2021

Conversation

andrewlukoshko
Copy link
Contributor

@andrewlukoshko andrewlukoshko commented Apr 19, 2021

Proposed Commit Message

Add support for AlmaLinux OS

AlmaLinux OS is RHEL-compatible so all the changes needed are trivial.

Additional Context

http://www.almalinux.org

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@github-actions
Copy link

github-actions bot commented May 4, 2021

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging mitechie, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag mitechie to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label May 4, 2021
@TheRealFalcon
Copy link
Member

TheRealFalcon commented May 5, 2021

Hi @andrewlukoshko , thanks for the contribution. Overall this looks good. I have a few comments:

I noticed you added yourself to the CLA signers file, but have you signed the actual CLA too? I'm not seeing your information there. If you did, can you provide the date that you signed it?

A unit test is failing. Can you update it?

You should also add the distro to the README

Can you add a unit test to cloudinit/tests/test_util.py to verify that get_linux_distro() works as expected? It should very similar to one of the centos tests.

@TheRealFalcon TheRealFalcon self-assigned this May 5, 2021
@TheRealFalcon TheRealFalcon removed the stale-pr Pull request is stale; will be auto-closed soon label May 5, 2021
@andrewlukoshko
Copy link
Contributor Author

@TheRealFalcon thanks for help with this PR.
I've updated tests and README and now check passed.
And I signed CLA too.

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheRealFalcon TheRealFalcon merged commit 8cf40a7 into canonical:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants