[DPE-3468] support for Juju Secrets on Cross-charm relations #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juditnovak
force-pushed
the
DPE-3768_data_interfaces_upgrade
branch
2 times, most recently
from
1580653
to
a1b3e83
Compare
juditnovak
force-pushed
the
DPE-3768_data_interfaces_upgrade
branch
from
a1b3e83
to
c1482ab
Compare
juditnovak
changed the title
juditnovak
changed the title
juditnovak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving Cross-charm Relations Data access to
data_interfacesv27 and to use well-established intererfaces (no databag).The
set_secret()operation seems to only set app status, but NOT any secrets.Leaving it on databag for now.
NOTE: Tests added in #38