updated thumbnail for wallpaper #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://design-ubuntu-com-303.demos.haus |
bartaz
reviewed
Oct 31, 2023
templates/resources/index.html
Outdated
| @@ -121,7 +121,7 @@ <h3 class="p-heading--5">Wallpapers</h3> | |||
| class="col-4 u-hide--medium u-hide--small" | |||
| > | |||
| {{ image ( | |||
| url="https://assets.ubuntu.com/v1/5d68f7aa-ubuntu-lunar-wallpaper-thumbnail.png", | |||
| url="https://assets.ubuntu.com/v1/ec6cc515-wallpaper_minotaur_colour_1920x1080.png", | |||
| alt="", | |||
| width="1500", | |||
There was a problem hiding this comment.
@elioqoshi just to make sure image displays in correct aspect ratio please update the width and height props as well to be the same as image size (1920x1080).
There was a problem hiding this comment.
The aspect ratio should be the same, but I can update it as well.
There was a problem hiding this comment.
@bartaz updated the branch (sorry, I am a bit rusty with git and I think I didn't update the PR accordingly)
fixed thumbnail ratio
|
@bartaz is this good to go? |
I think so, I'm just trying to get the demo running just to QA it properly. |
bartaz
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the wallpaper thumbnail from Lunar to Mantic