-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 #218
v3 #218
Conversation
Demo starting at https://global-nav-218.demos.haus |
e78527b
to
06ca21d
Compare
@davegoddard42 @lyubomir-popov I've assigned you both to this for a review - I'm not sure what we want to do about the mobile view of this, as it is it's what we had in the global nav previously but contained within the navigation element, but it doesn't look particularly "Vanilla", so I'm looking for some guidance on how it should look: https://global-nav-218.demos.haus/ For more context/background, this is a chat I had with @lyubomir-popov and @bartaz about it in Mattermost: https://chat.canonical.com/canonical/pl/5bcdcwperb8tdnbkryi4xhuf3y |
Thanks @sowasred2012. Let me look at this more depth, and we can catch up on Monday @lyubomir-popov. We have a little more time now that the launch has been pushed back a month, so let's get it right. |
another alternative would be to have chevrons pointing right and so the nested items as views that slide right to left |
@sowasred2012 apologies, I've not been very attentive to this one. I'm worried about doing too much here as when we launch the mega nav, this drop down will have it's content reviewed and rationalised. I've set up some metrics to see what the current user interaction is like. Currently few people click on the "Products" drop down in its current state. Let's see what people click on within the dropdown itself - it's on the main page so won't take more than a day or two to get results. I'm tempted to drop the "Resources" and "About" things and have a list of products only. This would remove the need for nesting. Other solutions could be to feature the curren top 9 products plus a link to "About" and the engage pages. This would also get rid of the need for nesting. I'll wait for the metrics to come back, and chat to SEO. If we don't wnat to lose anything from there then we can look at how better to style it. Long term, this will be overhauled as part of the mega menu anyway, and I don't want to spend lots of time designing something that's soon redundant. Or I want to invest in designing something that has multiple applications. We will need to spend time on the mobile mega menu (I have ideas and rough designs but I'll need Lyubo's help in getting there). |
LGTM @sowasred2012 |
import { createNav } from '@canonical/global-nav'; | ||
createNav({ maxWidth: '80rem' }); | ||
``` | ||
3. You will then need to add the `.global-nav` class to a `ul.p-navigation__items` element within the navigation pattern. The module will look for this class and add the dropdown as the first item in the list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to optionally be able to use different class name and provide it as a param.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@sowasred2012 all good just one minor cosmetic thing: the space abve the muted heading is way too much. Can you replicae what happens when you have an hr followed by a muted heading? |
Done
QA
Fixes: https://github.com/canonical-web-and-design/web-squad/issues/4989