hotsos/cli: replace deprecated importlib.resources.path with files() #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the said function is deprecated in python 3.12 and will be removed. the new equivalent function is files(). replaced resources.path() in hotsos/cli/get_repo_info with files() and also updated the unit test. Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
|
files() is not included in 3.8 python API, so dropping this for now. |
This was referenced May 13, 2024
xmkg
added a commit
to xmkg/hotsos
that referenced
this pull request
Jul 4, 2024
we're aware that the importlib.path is being deprecated but we still want to support python 3.8, which does not have the `as_file` function. thus, also noticed that when the resources.path() used in a with clause, it raises an exception when the file is not present in Python 3.8.10, which is the latest python 3.8 version in Focal at the moment. Therefore, used contextlib.suppress(Exception) to deal with that as well. Relevant past MP's: canonical#864, canonical#854 Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
xmkg
added a commit
to xmkg/hotsos
that referenced
this pull request
Jul 4, 2024
we're aware that the importlib.path is being deprecated but we still want to support python 3.8, which does not have the `as_file` function. so, this patch suppresses the annoying deprecation warning. also noticed that when the resources.path() used in a with clause, it raises an exception when the file is not present in Python 3.8.10, which is the latest python 3.8 version in Focal at the moment. Therefore, used contextlib.suppress(Exception) to deal with that as well. Relevant past MP's: canonical#864, canonical#854 Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
xmkg
added a commit
to xmkg/hotsos
that referenced
this pull request
Jul 4, 2024
we're aware that the importlib.path is being deprecated but we still want to support python 3.8, which does not have the `as_file` function. so, this patch suppresses the annoying deprecation warning. also noticed that when the resources.path() used in a with clause, it raises an exception when the file is not present in Python 3.8.10, which is the latest python 3.8 version in Focal at the moment. Therefore, used contextlib.suppress(Exception) to deal with that as well. Relevant past MP's: canonical#864, canonical#854 Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
xmkg
added a commit
to xmkg/hotsos
that referenced
this pull request
Jul 12, 2024
we're aware that the importlib.path is being deprecated but we still want to support python 3.8, which does not have the `as_file` function. so, this patch suppresses the annoying deprecation warning. also noticed that when the resources.path() used in a with clause, it raises an exception when the file is not present in Python 3.8.10, which is the latest python 3.8 version in Focal at the moment. Therefore, used contextlib.suppress(Exception) to deal with that as well. Relevant past MP's: canonical#864, canonical#854 Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
xmkg
added a commit
to xmkg/hotsos
that referenced
this pull request
Jul 30, 2024
we're aware that the importlib.path is being deprecated but we still want to support python 3.8, which does not have the `as_file` function. so, this patch suppresses the annoying deprecation warning. also noticed that when the resources.path() used in a with clause, it raises an exception when the file is not present in Python 3.8.10, which is the latest python 3.8 version in Focal at the moment. Therefore, used contextlib.suppress(Exception) to deal with that as well. Relevant past MP's: canonical#864, canonical#854 Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the said function is deprecated in python 3.12 and will be removed. the new equivalent function is files(). replaced resources.path() in hotsos/cli/get_repo_info with files() and also updated the unit test.