Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Kratos and UI integration #27

Merged
merged 28 commits into from
Mar 6, 2023
Merged

Initial Kratos and UI integration #27

merged 28 commits into from
Mar 6, 2023

Conversation

natalian98
Copy link
Contributor

@natalian98 natalian98 commented Feb 6, 2023 •
edited
Loading

Initial integration with kratos and login ui charms:

  • added hydra-kratos relation interface to provide oauth2_provider_url (hydra admin API endpoint)
  • added configurable kratos_ui_url
  • updated hydra config file
  • updated unit tests
  • updated readme according to the current state of integration

Integration testing will be covered in bundle tests.

TODO: Publish the library and update LIBID after an initial review.

@natalian98 natalian98 changed the title Kratos and UI integration Initial Kratos and UI integration Feb 8, 2023
@natalian98 natalian98 marked this pull request as ready for review February 8, 2023 15:25
@natalian98 natalian98 requested a review from a team as a code owner February 8, 2023 15:25
gruyaume
gruyaume reviewed Feb 9, 2023
View reviewed changes
src/hydra_endpoints_provider.py Outdated Show resolved Hide resolved
lib/charms/hydra/v0/hydra_endpoints_info.py Outdated Show resolved Hide resolved
lib/charms/hydra/v0/hydra_endpoints_info.py Outdated Show resolved Hide resolved
lib/charms/hydra/v0/hydra_endpoints_info.py Outdated Show resolved Hide resolved
config.yaml Show resolved Hide resolved
nsklikas
nsklikas reviewed Feb 15, 2023
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
src/hydra_endpoints_provider.py Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
nsklikas
nsklikas reviewed Feb 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
gruyaume
gruyaume reviewed Feb 20, 2023
View reviewed changes
README.md Show resolved Hide resolved
lib/charms/hydra/v0/hydra_endpoints.py Outdated Show resolved Hide resolved
lib/charms/hydra/v0/hydra_endpoints.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
gruyaume
gruyaume reviewed Feb 20, 2023
View reviewed changes
lib/charms/hydra/v0/hydra_endpoints.py Outdated Show resolved Hide resolved
lib/charms/hydra/v0/hydra_endpoints.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
gruyaume
gruyaume reviewed Feb 20, 2023
View reviewed changes
tests/unit/test_charm.py Outdated Show resolved Hide resolved
gruyaume
gruyaume reviewed Feb 20, 2023
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
lib/charms/hydra/v0/hydra_endpoints.py Outdated Show resolved Hide resolved
lib/charms/hydra/v0/hydra_endpoints.py Outdated Show resolved Hide resolved
lib/charms/hydra/v0/hydra_endpoints.py Outdated Show resolved Hide resolved
@natalian98

This comment was marked as outdated.

Sign in to view
gruyaume
gruyaume reviewed Feb 23, 2023
View reviewed changes
src/charm.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
gruyaume
gruyaume reviewed Feb 23, 2023
View reviewed changes
src/charm.py Show resolved Hide resolved
nsklikas
nsklikas reviewed Feb 24, 2023
View reviewed changes
lib/charms/hydra/v0/hydra_endpoints.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
@natalian98 natalian98 requested a review from a team February 24, 2023 15:55
nsklikas
nsklikas reviewed Mar 2, 2023
View reviewed changes
src/charm.py Show resolved Hide resolved
@natalian98 natalian98 requested review from a team and gruyaume March 3, 2023 09:47
nsklikas
nsklikas previously approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have a small comment. Change it only if it makes sense.

lib/charms/hydra/v0/hydra_endpoints.py Outdated Show resolved Hide resolved
gruyaume
gruyaume reviewed Mar 3, 2023
View reviewed changes
lib/charms/hydra/v0/hydra_endpoints.py Outdated Show resolved Hide resolved
lib/charms/hydra/v0/hydra_endpoints.py Outdated Show resolved Hide resolved
@natalian98 natalian98 requested a review from a team March 6, 2023 10:33
This was referenced Mar 6, 2023
Closed
Closed
@natalian98 natalian98 merged commit 3ad32cc into main Mar 6, 2023
@natalian98 natalian98 deleted the IAM-81-integration branch March 6, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@massigori massigori massigori left review comments

@gruyaume gruyaume gruyaume left review comments

@PietroPasotti PietroPasotti PietroPasotti left review comments

@jnsgruk jnsgruk jnsgruk left review comments

@nsklikas nsklikas nsklikas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@natalian98 @jnsgruk @PietroPasotti @gruyaume @nsklikas @massigori