fix: drop MetricInterface and adjust interface methods

canonical · Aug 22, 2023 · 50542f6 · 50542f6
1 parent b47dcf7
commit 50542f6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/internal/monitoring/interfaces.go b/internal/monitoring/interfaces.go
@@ -2,9 +2,6 @@ package monitoring
 
 type MonitorInterface interface {
 	GetService() string
-	GetResponseTimeMetric(map[string]string) (MetricInterface, error)
-}
-
-type MetricInterface interface {
-	Observe(float64)
+	SetResponseTimeMetric(map[string]string, float64) error
+	SetDependencyAvailability(map[string]string, float64) error
 }
diff --git a/internal/monitoring/middlewares.go b/internal/monitoring/middlewares.go
@@ -39,15 +39,7 @@ func (mdw *Middleware) ResponseTime() func(http.Handler) http.Handler {
 					"status": fmt.Sprint(ww.Status()),
 				}
 
-				m, err := mdw.monitor.GetResponseTimeMetric(tags)
-
-				if err != nil {
-					mdw.logger.Debugf("error fetching metric: %s; keep going....", err)
-
-					return
-				}
-
-				m.Observe(time.Since(startTime).Seconds())
+				mdw.monitor.SetResponseTimeMetric(tags, time.Since(startTime).Seconds())
 			},
 		)
 	}