-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Documentation update review #172
Conversation
Co-authored-by: Andreia Velasco <avgomes42@gmail.com>
Co-authored-by: Andreia Velasco <avgomes42@gmail.com>
Co-authored-by: Andreia Velasco <avgomes42@gmail.com>
Co-authored-by: Andreia Velasco <avgomes42@gmail.com>
Co-authored-by: Andreia Velasco <avgomes42@gmail.com>
Co-authored-by: Andreia Velasco <avgomes42@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I really like the new reference tables.
Co-authored-by: Andreia Velasco <avgomes42@gmail.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
Co-authored-by: Rob Gibbon <robgibbon@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deusebio @a-velasco fyi related to changing command relate -> integrate
.
[~]$ j remove-integration kafka zookeeper
ERROR juju: "remove-integration" is not a juju command. See "juju --help".
Did you mean:
remove-relation
Should we keep it as relate
until remove-integration
exists?
I'm not sure there is any plan in Juju to also have Anyhow, I don't mind too much. Up to @a-velasco to make a call such that we keep documentation consistent across DP. |
Actually I just found this just spot on. TLDR
|
superseded by #175 |
@grobbie @marcoppenheimer @zmraul @a-velasco