Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

katib-* missing unit and integration tests #5

Open
DnPlas opened this issue Jul 20, 2022 · 2 comments
Open

katib-* missing unit and integration tests #5

DnPlas opened this issue Jul 20, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Jul 20, 2022

All katib charms are missing "charm level" unit tests and "bundle level" integration tests.
@DnPlas DnPlas added enhancement New feature or request good first issue Good for newcomers labels Jul 20, 2022
@DnPlas
Copy link
Contributor Author

DnPlas commented Oct 12, 2022

Partially fixed by #33

@bschimke95
Copy link

Hi @DnPlas

I recently joined Canonical. One part of my on-boarding is to improve the test-coverage of a charm project and I'd be interested in adding the missing tests here.

Looking at the code it seems like that currently the katib-ui charm is missing unit- and integration tests.

Is it fine for you if I take this over? If so, are there any specifics/conventions for this repo or charmed kubeflow in general that I should keep in mind when implementing the tests?

bschimke95 added a commit to bschimke95/katib-operators that referenced this issue Sep 18, 2023
@bschimke95
Add unit and integration tests for kati-ui charm
6bfe6fc 
Unit tests cover basic pebble and leader implementation.
Integration test checks if charm builds and deploys and that the
katib-ui server is coming up.

Relates to canonical#5
@bschimke95 bschimke95 mentioned this issue Sep 18, 2023
Closed
@DnPlas DnPlas mentioned this issue Sep 21, 2023
Open
DnPlas pushed a commit that referenced this issue Sep 21, 2023
@bschimke95 @DnPlas
Add unit and integration tests for kati-ui charm
31187b3 
Unit tests cover basic pebble and leader implementation.
Integration test checks if charm builds and deploys and that the
katib-ui server is coming up.

Relates to #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DnPlas @bschimke95