Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanning scripts are only checking for upstream images and not the OCI images used by the charms #220

Open
kimwnasptd opened this issue Aug 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@kimwnasptd
Copy link
Contributor

Bug Description

The current tools/get-images.sh script will not detect and expose images used by the Charms. So if we integrate a rock, via the config #140, then the scripts would not detect this.

More info on how the scripts gather the images, look at #142 that explains the initial rationale

To Reproduce

./tools/get-images.sh

Environment

Current main and track/1.12 from 22 August 2024

Relevant Log Output

<none>

Additional Context

No response

@kimwnasptd kimwnasptd added the bug Something isn't working label Aug 22, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6143.

This message was autogenerated

@kimwnasptd
Copy link
Contributor Author

An option here would be to

  1. include all of the images as config options
  2. remove the version config options from the charms, since the Charms are already defined for a specific version in the branch

The above will require that we own all the images and expose them to the config options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant