Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Konf output for demos #31

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix Konf output for demos #31

merged 1 commit into from
Jul 5, 2022

Conversation

jkfran
Copy link
Contributor

@jkfran jkfran commented Jul 5, 2022

Done

  • Konf was returning values for staging (introduced on #21) that we shouldn't set for demos

QA

Install current konf with: sudo snap install konf
Check out this branch and compare that both outputs for demos are the same, eg:

konf demo ../../Workspace/snapcraft.io/konf/site.yaml --database-url postgres://postgres:POSTGRES_PW@postgres:5432/DATABASE_NAME -o domain=DEMO_DOMAIN image=IMAGE_NAME tlsName=demos-haus secretKey=demos-haus -l github.org=REPO_ORG github.repo=REPO_NAME github.pr=PR --tag IMAGE_TAG > a.yaml

./konf.py demo ../../Workspace/snapcraft.io/konf/site.yaml --database-url postgres://postgres:POSTGRES_PW@postgres:5432/DATABASE_NAME -o domain=DEMO_DOMAIN image=IMAGE_NAME tlsName=demos-haus secretKey=demos-haus -l github.org=REPO_ORG github.repo=REPO_NAME github.pr=PR --tag IMAGE_TAG > b.yaml

diff a.yaml b.yaml

The diff output should be empty

Copy link
Contributor

@goulinkh goulinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jkfran jkfran merged commit 1a4bda6 into main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants