Add tests for handling disk devices with long names #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamistao
force-pushed
the
test_handling_vms_with_long_names
branch
2 times, most recently
from
5785f74
to
9dc5284
Compare
hamistao
force-pushed
the
test_handling_vms_with_long_names
branch
2 times, most recently
from
7f6719f
to
e2af9b8
Compare
hamistao
changed the title
|
@tomponline I changed the approach of this PR from using long VM names to using long device names because that way we can check for regressions for both #13320 and #15516. |
roosterfish
previously requested changes
Jun 3, 2024
hamistao
force-pushed
the
test_handling_vms_with_long_names
branch
from
e2af9b8
to
81c4623
Compare
simondeziel
reviewed
Jun 3, 2024
hamistao
force-pushed
the
test_handling_vms_with_long_names
branch
2 times, most recently
from
71c08cf
to
52ac028
Compare
simondeziel
reviewed
Jun 3, 2024
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
hamistao
force-pushed
the
test_handling_vms_with_long_names
branch
from
52ac028
to
351b7f3
Compare
tomponline
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devices with long names can cause some problems due to socket paths or device tags that include those names being too long, resulting in errors from QEMU. See #13320 and #15516.