Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all forms submit when pressing enter on an input field #481

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Ensure all forms submit when pressing enter on an input field #481

merged 1 commit into from
Oct 5, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Oct 5, 2023

Done

  • some forms did not submit when pressing enter from an input field, that should be fixed now.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • ensure all forms still work and submit on enter press from an input field

@webteam-app
Copy link

Demo starting at https://lxd-ui-481.demos.haus

@edlerd edlerd requested a review from lorumic October 5, 2023 10:41
aaryanporwal
aaryanporwal approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@aaryanporwal aaryanporwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@edlerd edlerd merged commit a7b22e4 into canonical:main Oct 5, 2023
5 checks passed
@edlerd edlerd deleted the submit-forms-on-enter branch October 5, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaryanporwal aaryanporwal aaryanporwal approved these changes

@lorumic lorumic Awaiting requested review from lorumic

Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlerd @webteam-app @aaryanporwal