Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for custom volumes and networks #501

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add tests for custom volumes and networks #501

merged 1 commit into from
Oct 24, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Oct 23, 2023

Done

  • add e2e tests for profiles and instances that use disk and network devices

Fixes WD-6844

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • ensure test suite is passing

@webteam-app
Copy link

Demo starting at https://lxd-ui-501.demos.haus

lorumic
lorumic approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments, but it's essentially ready to go.

tests/helpers/profile.ts Outdated Show resolved Hide resolved
tests/helpers/devices.ts Outdated Show resolved Hide resolved
@edlerd edlerd requested a review from lorumic October 24, 2023 13:31
@edlerd edlerd merged commit 7825553 into canonical:main Oct 24, 2023
5 checks passed
@edlerd edlerd deleted the device-tests branch December 1, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaryanporwal aaryanporwal Awaiting requested review from aaryanporwal

@lorumic lorumic Awaiting requested review from lorumic

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlerd @webteam-app @lorumic