Optimise usage of setLoading/setSubmitting functions #508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
setLoading(false)
andsetSubmitting(false)
throughout the app, following these criteria:setLoading
/setSubmitting
should be called inside thefinally
block.setLoading
/setSubmitting
should be called inside thecatch
block (not needed for the success block as we navigate).setLoading
in the success block when there was already a call in thefinally
block).Files affected by #506 are intentionally excluded from the scope of this PR.
QA