Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show size hidden columns in instance table column toggle #510

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Oct 26, 2023

Done

  • add a visual indicator to the instance table column toggle for columns that are hidden because of narrow screen widths (previously a selected column in the column toggle might have been hidden for a smaller screen with no indication to the user. Leaving the user in the assumption the toggle doesn't work correctly)

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • display instance table on various screen widths and use the column toggle

@webteam-app
Copy link

Demo starting at https://lxd-ui-510.demos.haus

@acarege
Copy link

acarege commented Oct 27, 2023

Looks good to me!

Minor note for the future: It might be good to state what it is that the user selects aka the columns in the box that opens when the user clicks on it. For example: In a sentence: 5 out of 5 columns are selected. or as a title: "Columns"

@edlerd
Copy link
Collaborator Author

edlerd commented Oct 27, 2023

Looks good to me!

Minor note for the future: It might be good to state what it is that the user selects aka the columns in the box that opens when the user clicks on it. For example: In a sentence: 5 out of 5 columns are selected. or as a title: "Columns"

Thanks for the review. I'll add the word "columns" to the caption.

Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, apart from that it's good to go.

src/components/TableColumnsSelect.tsx Outdated Show resolved Hide resolved
@edlerd edlerd merged commit 68bd2c8 into canonical:main Oct 27, 2023
5 checks passed
@edlerd edlerd deleted the show-size-hidden-columns branch October 27, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants