Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings page: improved alignment, end-aligned edit icon in read mode [WD-6659] #511

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Oct 26, 2023

Done

  • Improved baseline alignment of the top row in the 3 columns of the settings table
  • End-aligned the edit icon in read mode

Fixes WD-6659

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Go to settings page
    • Check that alignment and visual appearance are as expected

Screenshots

  • Read mode:

Screenshot from 2023-10-26 13:18:44

  • Edit mode:

Screenshot from 2023-10-26 13:20:23

@webteam-app
Copy link

Demo starting at https://lxd-ui-511.demos.haus

@lorumic lorumic changed the title Improve alignment, end-align edit icon in read mode [WD-6659] Settings page: improved alignment, end-aligned edit icon in read mode [WD-6659] Oct 26, 2023
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acarege
Copy link

acarege commented Oct 27, 2023

Design is good to go!

@edlerd edlerd merged commit 412d1e4 into canonical:main Oct 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants