-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry for network changes on localhost #512
Conversation
Demo starting at https://lxd-ui-512.demos.haus |
…etry logic for those cases
fcacb75
to
6686777
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix makes sense, and I expect it to work even if I cannot test it, but it's a somewhat ugly workaround. Do we have an idea of what is the root cause of this problem? How was this found? Might be worth discussing it with the core team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve, but I still suggest to consider what I wrote in the previous comment:
The fix makes sense, and I expect it to work even if I cannot test it, but it's a somewhat ugly workaround. Do we have an idea of what is the root cause of this problem? How was this found? Might be worth discussing it with the core team?
Opened an issue canonical/lxd#12475 |
Well done, thanks! |
Merged as upstream has a hard time finding a fix and we want the UI to be without this bug. |
Done
QA