Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use web worker for certificate generation WD-6613 #515

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Use web worker for certificate generation WD-6613 #515

merged 1 commit into from
Oct 30, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Oct 27, 2023 •
edited
Loading

Done

  • extract the certificate generation into a web worker process

Fixes: WD-6613

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • replace line 53 in auth.tsx with isAuthenticated: false
    • open the url /ui/login/certificate-generate
    • click generate and ensure the certs are created successfully.

@webteam-app
Copy link

Demo starting at https://lxd-ui-515.demos.haus

@edlerd edlerd merged commit a5eb938 into canonical:main Oct 30, 2023
5 checks passed
@edlerd edlerd deleted the web-worker-certificates branch October 30, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorumic lorumic lorumic approved these changes

@aaryanporwal aaryanporwal Awaiting requested review from aaryanporwal

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlerd @webteam-app @lorumic