Improve networking

[edlerd]

Done

• address various issues around network creation/editing discovered during in person review. Notes are in this doc
• remove fan network type (simplifies bridge network handling)
• streamline copy on network forms
• fix ovn uplink network list to respect restricted.networks.uplinks setting for project, when that is unset, the non-ovn networks from the default project should be displayed in the list.

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
   • With a local copy of this branch, run as described here.
2. Perform the following QA steps:
   • created a bridge network
   • edit a bridge network
   • if ovn available, create / edit an ovn network
   • if ovn available, setup a project with restricted.networks.uplinks set. Enter some network names from the default project into project configuration > Allow custom restrictions on a project level > Restrictions > Networks > Network uplinks. Only networks explicitly listed should be available as uplink, when creating an ovn network in that project.

[webteam-app]

Demo starting at https://lxd-ui-529.demos.haus

[lorumic]

Please make the "Uplink" field a required one for OVN:

[edlerd]

Please make the "Uplink" field a required one for OVN:

It can be empty, when no networks are available to the current user, the default network from the default profile will then be used. So changed it to be required, when at least 1 network to select from is available.

[lorumic]

It can be empty, when no networks are available to the current user, the default network from the default profile will then be used. So changed it to be required, when at least 1 network to select from is available.

Can we make it disable the "Create" button, just like the "Name" field does when you input a name that is already assigned to another network?

[edlerd]

Can we make it disable the "Create" button, just like the "Name" field does when you input a name that is already assigned to another network?

Disabling the button now. Also the selectable networks as uplinks are now properly filtered.

Added some docs for how to test OVN in the wiki.

[lorumic]

I still have problems creating the OVN network. I get the "Option "network" value "UPLINK" is not one of the allowed uplink networks in project" error, even though I added it (and it is indeed correctly shown in the dropdown). See the screen capture below:

[edlerd]

I still have problems creating the OVN network. I get the "Option "network" value "UPLINK" is not one of the allowed uplink networks in project" error, even though I added it (and it is indeed correctly shown in the dropdown). See the screen capture below:

I don't really know why this is happening, I suspect a wrong error message from the backend. With the OVN setup described in the wiki I can create OVN networks through the UI.

Edit: Regarding the error, can you either ask in the LXD-UI mattermost, or add it to the next sync agenda so we can figure this out? I won't see it as a blocker for this PR though?

[lorumic]

Thanks, with microcloud it works. Probably I misconfigured something when I enabled OVN in the other cluster.

[lorumic]

Looks good overall, just a couple of small suggestions.