Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make snapshot name optional #555

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Make snapshot name optional #555

merged 1 commit into from
Nov 23, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Nov 23, 2023

Done

  • make snapshot name optional, LXD will figure out the next name automatically, when not set.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • go to an instance > snapshots > create snapshot. Create a snapshot with or without a name. Both should work.

@webteam-app
Copy link

Demo starting at https://lxd-ui-555.demos.haus

@edlerd edlerd merged commit d087fb2 into canonical:main Nov 23, 2023
5 checks passed
@edlerd edlerd deleted the snapshot-name-optional branch November 23, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaryanporwal aaryanporwal aaryanporwal approved these changes

Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlerd @webteam-app @aaryanporwal