Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project details form: move notification row out of scrollable area #564

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Dec 1, 2023

Done

In the project configuration page, that unlike the ones for instances and profiles has no tabs, the notification of the outcome of an edit operation resulted to be hidden on medium/low window heights, as shown in the screen capture below:

Peek 2023-12-01 12-12

This can be easily solved by moving the notification row outside of the scrollable area:

Peek 2023-12-01 12-13

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Open the project configuration page
    • Select "Customised" features from the dropdown
    • Reduce the window height if needed
    • Toggle the custom restrictions as shown in the screen captures below
    • Check that the notification of the result of the operation is immediately visible, and you don't have to manually scroll up to see it

@webteam-app
Copy link

Demo starting at https://lxd-ui-564.demos.haus

@lorumic lorumic force-pushed the fix-hidden-notification branch 4 times, most recently from 50ca761 to 6a70cbd Compare December 1, 2023 11:51
Signed-off-by: lorumic <michele.lorusso@canonical.com>
@mas-who
Copy link
Collaborator

mas-who commented Dec 1, 2023

LGTM

@lorumic lorumic merged commit e333971 into canonical:main Dec 1, 2023
6 checks passed
@lorumic lorumic deleted the fix-hidden-notification branch December 1, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants