Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass dynamicHeight as DOM attribute to textarea #571

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Dec 7, 2023

Done

  • A tiny change to remove a React warning, complaining that an unrecognised "dynamicHeight" prop was being set on a DOM element:

Screenshot from 2023-12-07 20:38:06

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access. The warning seems to appear only when running locally (dev).
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Open the browser console from the dev tools
    • Go to a page where there is an auto-expanding textarea, e.g. the instance detail page, configuration tab
    • Check that no warning like the one in the screenshot above appears in the console

Signed-off-by: lorumic <michele.lorusso@canonical.com>
@webteam-app
Copy link

Demo starting at https://lxd-ui-571.demos.haus

@mas-who
Copy link
Collaborator

mas-who commented Dec 8, 2023

Thank you for the fix!

@mas-who mas-who merged commit 2fac990 into canonical:main Dec 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants