Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: publish test reports to github pages [WD-7907] #579

Merged
merged 1 commit into from
Dec 13, 2023
Merged

chore: publish test reports to github pages [WD-7907] #579

merged 1 commit into from
Dec 13, 2023

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Dec 12, 2023 •
edited
Loading

Done

  • Created an orphan branch gh-pages from which github pages for this repository will deploy
  • Added a new job in pr.yaml to use the artifact produced by the e2e test job and push it to the gh-pages branch. This takes into consideration that multiple pr actions may be running at the same time. Lastly, the job will run if the e2e tests failed or succeeded and output a url for the test reports.
  • Added a new action triggered on PR merge so that test reprorts gets cleaned up on the gh-pages branch.

@webteam-app
Copy link

Demo starting at https://lxd-ui-579.demos.haus

@mas-who mas-who force-pushed the playwright-to-gh-pages branch 8 times, most recently from b35e895 to a44e292 Compare December 13, 2023 11:12
@mas-who mas-who requested a review from edlerd December 13, 2023 11:21
edlerd
edlerd reviewed Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite nice. Some questions and ideas below. Happy to discuss them over a call.

.github/workflows/delete_test_reports.yml Show resolved Hide resolved
.github/workflows/delete_test_reports.yml Outdated Show resolved Hide resolved
.github/useful_act_commands.md Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
.github/workflows/delete_test_reports.yml Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
workflow: add HTML report for PR #579 (run_id: 7196267872, attempt: 1)
743bddc
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
workflow: add HTML report for PR #579 (run_id: 7196585804, attempt: 1)
b81157c
mas-who pushed a commit that referenced this pull request Dec 13, 2023
workflow: remove all reports for PR #579
ee63835
mas-who pushed a commit that referenced this pull request Dec 13, 2023
workflow: remove all reports for PR #579
2fb239a
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
workflow: add HTML report for PR #579 (run_id: 7197205057, attempt: 1)
8ee6c6b
edlerd
edlerd approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit about the commenting of the while loops. Feel free to merge as is though.

.github/workflows/delete_test_reports.yml Show resolved Hide resolved
@mas-who
chore: publish test reports to github pages
d355838 
Signed-off-by: Mason Hu <mason.hu@canonical.com>
@mas-who
Copy link
Collaborator Author

mas-who commented Dec 13, 2023

LGTM, just one nit about the commenting of the while loops. Feel free to merge as is though.

Aaah right, it's a shell script actually so it should be fine. I've moved the comment to within the run command on both actions now.

github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
workflow: add HTML report for PR #579 (run_id: 7197641450, attempt: 1)
d10177d
@mas-who mas-who changed the title chore: publish test reports to github pages chore: publish test reports to github pages [WD-7907] Dec 13, 2023
@mas-who mas-who merged commit 9044dcd into main Dec 13, 2023
7 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
workflow: remove all reports for PR #579
7e3abbf
@edlerd edlerd deleted the playwright-to-gh-pages branch February 21, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mas-who @webteam-app @edlerd