Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(storage): support ceph storage pool [WD-7968] #597

Merged
merged 1 commit into from
Jan 12, 2024
Merged

feature(storage): support ceph storage pool [WD-7968] #597

merged 1 commit into from
Jan 12, 2024

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Jan 8, 2024 •
edited
Loading

Done

Things required code changes

  • CRUD storage pool with ceph (RBD) driver
  • CRUD storage pool with ceph (RBD) driver in LXD cluster
  • Prevent ceph storage volumes from being attached to more than one instance

Things that didn't require code changes but tested locally

  • Add, edit and delete custom storage volumes in ceph storage pool
  • Add, edit, delete and restore snapshots for ceph custom storage volumes

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Setup a Ceph cluster using LXD VMs and microceph
    • Create, edit and delete storage pool with ceph driver
    • Create, edit and delete custom storage volume in ceph storage pool
    • Create, edit, delete and restore snapshots for ceph custom storage volumes
    • Create and run instances in ceph storage pool
    • Create and run instances with ceph custom storage volumes attached

@webteam-app
Copy link

Demo starting at https://lxd-ui-597.demos.haus

@mas-who mas-who force-pushed the support-ceph-storage branch 2 times, most recently from aa0e129 to 6e48944 Compare January 9, 2024 08:57
@mas-who mas-who marked this pull request as ready for review January 9, 2024 09:15
@mas-who mas-who force-pushed the support-ceph-storage branch 3 times, most recently from afb9fd2 to d459593 Compare January 10, 2024 07:11
edlerd
edlerd reviewed Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA wise all works well. Some ideas to simplify and some questions below.

src/api/storage-pools.tsx Outdated Show resolved Hide resolved
src/context/loadCustomVolumes.tsx Outdated Show resolved Hide resolved
src/pages/storage/CreateStoragePool.tsx Outdated Show resolved Hide resolved
src/pages/storage/CreateStoragePool.tsx Outdated Show resolved Hide resolved
src/pages/storage/EditStoragePool.tsx Outdated Show resolved Hide resolved
src/pages/storage/forms/StoragePoolFormMenu.tsx Outdated Show resolved Hide resolved
src/pages/storage/forms/StoragePoolFormCeph.tsx Outdated Show resolved Hide resolved
src/pages/storage/forms/StorageVolumeFormMenu.tsx Outdated Show resolved Hide resolved
src/util/configInheritance.tsx Show resolved Hide resolved
src/util/storageOptions.tsx Outdated Show resolved Hide resolved
@mas-who mas-who force-pushed the support-ceph-storage branch 7 times, most recently from a4f7d03 to 15109d5 Compare January 11, 2024 08:29
edlerd
edlerd reviewed Jan 11, 2024
View reviewed changes
src/context/loadCustomVolumes.tsx Outdated Show resolved Hide resolved
src/pages/storage/CreateStoragePool.tsx Outdated Show resolved Hide resolved
src/pages/storage/EditStoragePool.tsx Outdated Show resolved Hide resolved
edlerd
edlerd approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one change of a wrong import from the previous code.

src/pages/storage/forms/StoragePoolForm.tsx Outdated Show resolved Hide resolved
@mas-who
feature(storage): support ceph storage pool [WD-7968]
91ecf34 
- Create storage pool with ceph (RBD) driver
- Edit ceph storage pool configs
- Add custom storage volumes in ceph storage pool
- Edit custom storage volumes in ceph storage pool
- Add, edit, delete and restore snapshots for ceph custom storage volumes
- Support for all of the above operations for an LXD cluster
- Prevent ceph storage volumes from being attached to more than one instance

Signed-off-by: Mason Hu <mason.hu@canonical.com>
@mas-who
Copy link
Collaborator Author

mas-who commented Jan 11, 2024

I don't think a design review is actually necessary for this one since everything we added was based on existing designs.

@mas-who mas-who merged commit f1853ee into canonical:main Jan 12, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
workflow: remove all reports for PR #597
8d55650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mas-who @webteam-app @edlerd