-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix safari regressions [WD-7486] #601
Conversation
Demo starting at https://lxd-ui-601.demos.haus |
514a210
to
79c0cbf
Compare
79c0cbf
to
515c343
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you rebase on main and see if the tests succeed after that (there was a fix in main for tests)?
515c343
to
e6e1901
Compare
I've rebased on main, but it still seems to be failing, couldn't pin point why. |
e6e1901
to
e78ed3a
Compare
Signed-off-by: Aaryan Porwal <aaryan.porwal@canonical.com>
e78ed3a
to
5a94be4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good QA and code wise and tests are passing. Thanks for the fixes 👍
Done
align-items: center
to breadcrumb for because info icon was not aligned perfectly with the breadcrumb.This changes don't show regressions in chrome, but fixes issues in safari.
Fixes WD-7486
QA
Screenshots
Before:
The screenshots for "Before" are attached in https://warthogs.atlassian.net/browse/WD-7486
After:
Selectable main table:
Breadcrumbs:
[Before]: Breadcrumb with info icon:
[After]: Breadcrumb with info icon: