Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid prompt on navigation away from terminal after session close #606

Merged

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jan 17, 2024

Done

  • Avoid prompt on navigation away from terminal when the websocket for the terminal is closed

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • create & start instance
    • open instance detail page > terminal, interact with terminal, try to navigate by clicking and ensure a warning is displayed, and you can stay on the page with the warning. Stop the instance directly or in another tab. Ensure the warning on navigation is not displayed after the terminal was interacted with.
    • repeat test for text console

@webteam-app
Copy link

Demo starting at https://lxd-ui-606.demos.haus

Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good code- and QA-wise. However, the commit seems to not be signed off.

…minal websocket is closed

Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd edlerd force-pushed the allow-terminal-navigation-when-ws-closed branch from a8816fd to 2400864 Compare January 17, 2024 12:28
@edlerd edlerd merged commit 73f6b79 into canonical:main Jan 17, 2024
6 checks passed
@edlerd edlerd deleted the allow-terminal-navigation-when-ws-closed branch January 17, 2024 21:41
github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants