chore: add test for using instance terminal [WD-8310] #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://lxd-ui-626.demos.haus |
edlerd
reviewed
Jan 30, 2024
tests/instances.spec.ts
Outdated
| const terminalInput = page.getByRole("textbox", { name: "Terminal input" }); | ||
| await terminalInput.fill("lsb_release -a"); | ||
| await terminalInput.press("Enter"); | ||
| await expect(page.locator(".xterm-rows")).toContainText("jammy"); |
There was a problem hiding this comment.
This is going to change for sure. Maybe check for the text "Distributor ID:", or something else that is not expected to change?
There was a problem hiding this comment.
Changed the text check to Ubuntu. Although in createInstance we always select a jammy image, will we update that to the next lts version released?
There was a problem hiding this comment.
I guess we will change it in the future. Maybe it should be a constant? Not sure how to make the test more stable. Or keep with ubuntu it should be fine as well.
There was a problem hiding this comment.
Yeah I think for this specific test using Ubuntu should be fine 👍
Signed-off-by: Mason Hu <mason.hu@canonical.com>
mas-who
force-pushed
the
add-terminal-test
branch
from
64f8187
to
cd25ea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA