New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage #634

Merged

edlerd merged 1 commit into canonical:main from edlerd:coverage

Feb 21, 2024

Collaborator

edlerd commented Feb 5, 2024 •

edited

Loading

Done

adding coverage for test runs

Fixes WD-8680

QA

Perform the following QA steps:
- ensure CI pipeline is passing
- check the CI step emitted test coverage step i.e. this text report or the artifact on this summary
- push to gh-pages tested in this fork action and verified it on the forks gh-pages branch

edlerd added the Don't merge label

edlerd force-pushed the coverage branch 6 times, most recently from ffc75aa to 92aa46d Compare

February 16, 2024 17:33

edlerd mentioned this pull request

chore(test): added tests for multiple lxd server versions [WD-8616] #653

Merged

edlerd force-pushed the coverage branch 6 times, most recently from 33cd89f to 5c53396 Compare

February 20, 2024 10:05

edlerd added Review: Code needed Review: QA needed and removed Don't merge labels

edlerd marked this pull request as ready for review

February 20, 2024 10:13

edlerd force-pushed the coverage branch 12 times, most recently from 198f84a to 9e1bbed Compare

February 20, 2024 13:33

edlerd force-pushed the coverage branch 2 times, most recently from c42b1cc to 12942f7 Compare

February 20, 2024 13:37

edlerd changed the title ~~chore(tests) add test coverage~~ Add test coverage

mas-who reviewed

View reviewed changes

.github/workflows/coverage.yaml Outdated Show resolved Hide resolved

edlerd force-pushed the coverage branch from 12942f7 to 0845a2b Compare

February 21, 2024 12:03

mas-who reviewed

View reviewed changes

playwright.config.ts Outdated Show resolved Hide resolved

mas-who reviewed

View reviewed changes

vitest.config.ts Show resolved Hide resolved

mas-who reviewed

View reviewed changes

package.json Outdated Show resolved Hide resolved

edlerd force-pushed the coverage branch from 0845a2b to 96ca42a Compare

February 21, 2024 12:27

mas-who reviewed

View reviewed changes

tests/fixtures/coverage.ts Show resolved Hide resolved

tests/fixtures/coverage.ts Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

tests/instance-panel.spec.ts Show resolved Hide resolved

package.json Show resolved Hide resolved

.github/workflows/coverage.yaml Show resolved Hide resolved

Collaborator

mas-who commented Feb 21, 2024

QA on this forked action, will check once done.

edlerd force-pushed the coverage branch from 96ca42a to 668074f Compare

February 21, 2024 13:18

Collaborator

mas-who commented Feb 21, 2024 •

edited

Loading

QA looks good https://mas-who.github.io/lxd-ui/coverage/, numbers match between the text output in action run and the final report upload.

mas-who added Review: QA +1 and removed Review: QA needed labels

edlerd force-pushed the coverage branch from 668074f to 1f4e262 Compare

February 21, 2024 14:21

edlerd requested a review from mas-who

February 21, 2024 14:25

edlerd force-pushed the coverage branch 2 times, most recently from a332c8e to 8765304 Compare

February 21, 2024 15:10


          chore(tests) add test coverage

43cb485

Signed-off-by: David Edler <david.edler@canonical.com>

edlerd force-pushed the coverage branch from 8765304 to 43cb485 Compare

February 21, 2024 15:40

mas-who added Review: Code +1 and removed Review: Code needed labels

mas-who approved these changes

View reviewed changes

edlerd merged commit 0427e00 into canonical:main

10 checks passed

edlerd deleted the coverage branch

February 21, 2024 16:24

github-actions bot pushed a commit that referenced this pull request


          workflow: remove all reports for PR #634

7ceedba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review: Code +1 Review: QA +1