-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(doc): added new instructions for e2e test with different lxd versions [WD-9034] #666
Conversation
Demo starting at https://lxd-ui-666.demos.haus |
HACKING.md
Outdated
|
||
npx playwright test | ||
snap refresh lxd --channel 5.0/stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe suggest to use latest/edge
here, so the next command below test-e2e-edge
is connected?
ARCHITECTURE.MD
Outdated
@@ -12,6 +12,8 @@ For the production release, [LXD](https://github.com/canonical/lxd) is pulling t | |||
|
|||
In a clustered LXD environment the LXD-UI is available on all nodes, so you can query it from any cluster member. Authentication is shared between all nodes. | |||
|
|||
LXD maintains different release branches in parallel. This includes long term support (LTS) releases which can have older versions of LXD bundled with LXD-UI. This means that LXD-UI should be compatible with older versions of LXD (v5.0 or later). Compatibility here means graceful degradation in the UI when certian features are missing in older LXD versions. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping we could describe how the test workflow is architected. Especially the matrix with channels and browsers. Also, how they are configured in pr.yaml
and the connection to the projects in playwright.config.ts
. Furthermore how the lxdVersion appears in the end to end tests and how it is used to enable / disable specific tests.
So instead of explaining why multiple version are there, explain how the different moving parts are working, and where they connect. Especially how they are configured, so we have a reference for future changes to the config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaaah sorry I misunderstood the assignment, will get that done 👍
a75566e
to
22286ed
Compare
I realised one thing, it is not easy to write documentation 😅 I hope the updated text makes sense |
c798e89
to
ef5c53e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks! some suggestions below, address them or keep as is -- up to you :)
…rsions Signed-off-by: Mason Hu <mason.hu@canonical.com>
ef5c53e
to
1f20938
Compare
Done
QA