Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi-select rows with shift key [WD-8506] #692

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Mar 8, 2024

Done

  • Add ability to multi select rows if the shift key is pressed.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Check normal select rows and bulk actions on the instance list and images list tables still work as expected
    • Check that multi select rows with shift key pressed works as expected i.e. select one row, the hold down shift key and select another row, all rows in between should be selected.

@webteam-app
Copy link

Demo starting at https://lxd-ui-692.demos.haus

@mas-who mas-who changed the title feat: multi-select rows with shift key feat: multi-select rows with shift key [WD-8506] Mar 8, 2024
@mas-who mas-who force-pushed the shift-multi-select branch 2 times, most recently from 70c09c6 to be7d17d Compare March 12, 2024 07:21
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this! Tiny nit below about clarifying the event listener for future us.

src/components/SelectableMainTable.tsx Show resolved Hide resolved
Signed-off-by: Mason Hu <mason.hu@canonical.com>
@mas-who mas-who merged commit a7743e0 into canonical:main Mar 12, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants